Skip to content

Add back superpmi pipeline files #43323

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kunalspathak merged 5 commits into from
Oct 13, 2020
Merged

Add back superpmi pipeline files #43323

kunalspathak merged 5 commits into from
Oct 13, 2020

Conversation

@kunalspathak
Copy link
Contributor

@kunalspathak kunalspathak commented Oct 12, 2020

In #42053 , the superpmi pipeline files were added in wrong folder and got deleted after auto-update from dotnet/arcade. Add back those files in right folder.

@Dotnet-GitSync-Bot Dotnet-GitSync-Bot added the area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI label Oct 12, 2020
@kunalspathak
Copy link
Contributor Author

kunalspathak commented Oct 12, 2020

@safern

@kunalspathak
Copy link
Contributor Author

kunalspathak commented Oct 12, 2020

I have triggered a run with these changes: https://dev.azure.com/dnceng/internal/_build/results?buildId=849372&view=results

BruceForstall
BruceForstall reviewed Oct 12, 2020
View reviewed changes
Copy link
Contributor

@BruceForstall BruceForstall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/coreclr/scripts seems like the wrong location for superpmi.proj. Wouldn't it be better in eng/pipelines/coreclr? It would be "next to" the users in that case.

@kunalspathak
Copy link
Contributor Author

kunalspathak commented Oct 12, 2020

src/coreclr/scripts seems like the wrong location for superpmi.proj. Wouldn't it be better in eng/pipelines/coreclr? It would be "next to" the users in that case.

True, but I didn't see any .proj files under eng/pipelines folder, so created it under src\coreclr\scripts. I am not sure if that is intentional or it is just that we have .proj files under src\coreclr. Let me know what you think and I will change it accordingly.

@safern
Copy link
Member

safern commented Oct 12, 2020

The pipelines folder usually just contains .yml files. So I think src/coreclr/* makes more sense...

@kunalspathak
add the missing import
0b0a36d
@kunalspathak
add another missing import
d174cf9 
I am not sure how this worked in the past with missing imports.
safern
safern reviewed Oct 12, 2020
View reviewed changes
safern
safern reviewed Oct 12, 2020
View reviewed changes
@kunalspathak kunalspathak merged commit 1c4f311 into dotnet:master Oct 13, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 7, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@safern safern safern approved these changes

+1 more reviewer

@BruceForstall BruceForstall BruceForstall left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-CodeGen-coreclr CLR JIT compiler in src/coreclr/src/jit and related components such as SuperPMI

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@kunalspathak @safern @BruceForstall @Dotnet-GitSync-Bot